Include HTTP proxy environment variables in default passenv #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
approved these changes
Jan 16, 2020
|
The CI failure looks unrelated, but I don'thave permission to restart that test in order to confirm. Can someone do so, please? |
philroche
added a commit
to philroche/lpshipit
that referenced
this pull request
Feb 9, 2021
If a proxy has been configured on the host using environment variables http_proxy or https_proxy then the container will inherit this proxy config for the default user [1]. However then calling sudo this proxy config is no longer configured. To fix this and so sudo calls use the same proxy we can use `--preserve-env` [2] to pass in a list of environment variables we want set for sudo user too. We don't have to set proxy for pip install explicitly as if the http_proxy or https_proxy variables are set then pip will use that proxy [3]. This is the case for tox too [4]. [1] https://lxd.readthedocs.io/en/latest/environment/ [2] http://manpages.ubuntu.com/manpages/focal/man8/sudo.8.html [3] https://pip.pypa.io/en/stable/user_guide/#using-a-proxy-server [4] tox-dev/tox#1500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTP proxy variables to the default passenv
Closes #1498
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)