Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add prelude section on testenvs to config guide

Merged
merged 3 commits into from May 2, 2020

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Apr 30, 2020

This information is currently found in the guide, but we jump straight into listing the various configuration options available before we actually describe what a testenv actually is. Fix this.

Note that I also had to tweak pre-commit to get it passing on my host.

stephenfin added 2 commits Apr 30, 2020
On Fedora 31 at least, pre-commit seems to be trying to use Python 2 by
default. This doesn't work and never will again, so force it to use
Python 3.

Signed-off-by: Stephen Finucane <stephen@that.guru>
This information is currently found in the guide, but we jump straight
into listing the various configuration options available before we
actually describe what a testenv actually is. Fix this.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit bdd1453 into tox-dev:master May 2, 2020
1 of 24 checks passed
@gaborbernat
Copy link
Member

gaborbernat commented May 2, 2020

Hello, this now has been released via https://pypi.org/project/tox/3.15.0/

heads up

@stephenfin stephenfin deleted the trivial branch May 2, 2020
``py37-django31`` (``py37``, ``django31``), ``py38-django30`` (``py38``,
``django30``), and ``py38-django31`` (``py38``, ``django31``). Combined, these
features provide the ability to write very concise ``tox.ini`` files and is
discussed further `below <generating-environments>`__.
Copy link
Contributor

@hugovk hugovk May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "below" link doesn't work:

From https://tox.readthedocs.io/en/latest/config.html#tox-environments section, it leads to https://tox.readthedocs.io/en/latest/generating-environments "SORRY This page does not exist yet."

Copy link
Contributor Author

@stephenfin stephenfin May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, this probably should have used :ref: rather than the double underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants