docs: Add prelude section on testenvs to config guide #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Fedora 31 at least, pre-commit seems to be trying to use Python 2 by default. This doesn't work and never will again, so force it to use Python 3. Signed-off-by: Stephen Finucane <stephen@that.guru>
This information is currently found in the guide, but we jump straight into listing the various configuration options available before we actually describe what a testenv actually is. Fix this. Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
approved these changes
May 2, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
|
Hello, this now has been released via https://pypi.org/project/tox/3.15.0/ |
hugovk
reviewed
May 5, 2020
| ``py37-django31`` (``py37``, ``django31``), ``py38-django30`` (``py38``, | ||
| ``django30``), and ``py38-django31`` (``py38``, ``django31``). Combined, these | ||
| features provide the ability to write very concise ``tox.ini`` files and is | ||
| discussed further `below <generating-environments>`__. |
There was a problem hiding this comment.
This "below" link doesn't work:
From https://tox.readthedocs.io/en/latest/config.html#tox-environments section, it leads to https://tox.readthedocs.io/en/latest/generating-environments "SORRY This page does not exist yet."
There was a problem hiding this comment.
Damn, this probably should have used :ref: rather than the double underscore
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
This was referenced Jan 9, 2023
Merged
stephenfin
added a commit
to stephenfin/tox
that referenced
this pull request
Jan 11, 2023
This was previously done in tox-dev#1573 but it seems to have gone missing in the rewrite. Re-add it. Signed-off-by: Stephen Finucane <stephen@that.guru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is currently found in the guide, but we jump straight into listing the various configuration options available before we actually describe what a testenv actually is. Fix this.
Note that I also had to tweak pre-commit to get it passing on my host.