Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list of how to install multiple Python versions #2476

Closed
wants to merge 5 commits into from

Conversation

niccokunzmann
Copy link

@niccokunzmann niccokunzmann commented Aug 7, 2022

This links to tutorials about how to install different Python versions alongside eachother.

Contributes to #2453 (comment)

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue Where to document installation of different Python versions #2453 (comment)
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

also add myself to the contributors
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want to maintain a blessed way of installing Python, 🤔 @jugmac00 what do you think?

@niccokunzmann
Copy link
Author

@gaborbernat thanks for taking your time and also for maintaining tox! I will not say that you have to maintain it - you can reject it - but I would like to clarify my reasoning:

  1. I develop Python for 17 years now and just now came across the need to install all required Python versions for testing with tox. That means: I am able to create this pull request and there is a need.
  2. In that situation: hundreds of projects use tox, should there be 100 such documentations or one?
  3. When I follow the install guide, I would usually (lazy/beginner) not install all Python versions for testing and just go with what I have. To successfully use tox, I should however install all Python versions required not just skip them. This change points into the right direction by putting the work on the community to guide and not the single developer.
  4. tox is incomplete to use without the versions of Python necessary.

I know, a tutorial list does not sound appealing. I think, it should be somewhere though. But where?

@gaborbernat
Copy link
Member

Just to clarify, I'm not saying we shouldn't do this, I'm just not 100% on this so I'd like the opinions of other maintainers to swing the pendulum one way or another 👍

Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned in the issue ( #2453 ), I like the idea in general.

I'd like to make sure two things, though:

  • we do not endorse one or another way on how to install an additional Python version
  • we do not give support for installing additional Python versions

docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Show resolved Hide resolved
docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Show resolved Hide resolved
docs/install.rst Show resolved Hide resolved
@asottile
Copy link
Contributor

asottile commented Aug 8, 2022

I don't think this has a place in tox's docs -- and it's trivial for someone to search the Internet to find how to install python

-1 for me

@niccokunzmann niccokunzmann changed the title add list of how to install mutiple Python versions add list of how to install multiple Python versions Aug 8, 2022
@gaborbernat
Copy link
Member

As Anthony also shares my concerns I decided to not add this part of tox 3. That being said tox 4 documentation will be constructed more along the lines of the https://diataxis.fr/ where I can see this happen within a tutorial.

@gaborbernat
Copy link
Member

Thanks for your contribution and sorry this did not get merged but we'll reuse it for tox 4 :-)

@niccokunzmann
Copy link
Author

niccokunzmann commented Aug 21, 2022 via email

@brunolnetto
Copy link

I like how we found a consensus on the issue. I bring one argument to the table: docker install script (available on https://get.docker.com/) manages multiple installations by ad-hoc infer procedure. Take a look at their functions. An alternative pathway is to do some tinkering and extract these OS-sniffer out of the script.

Luckily I managed to do it myself for fun. You may not trust my efforts, of course.

https://github.com/whosbash/shovel/blob/main/scripts/shell/os-utils.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants