PythonDeps: move cli_only
handling logic to _parse_requirements
#2547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli_only
parameter frombuild_parser
.--hash
option (only valid in requirements.txt files, notpip install
).PythonDeps._parse_requirements
:cli_only
logic forParsedRequirement
objects that directly come from thePythonDeps
.requirements.txt
lines to correctly parse--hash
(Fix tox4: fails to process requirement files with --hash #2373).--hash
is used in the deps list.#2373 [test case] tox4: fails to process requirement files with
--hash
--hash
in the deps list doesn't work (pip would reject this anyway).--hash
in a requirements.txt file named in the deps list should work, and recursive parsing should correctly extract the hash.Contribution checklist:
(also see CONTRIBUTING.rst for details)
CONTRIBUTORS
(preserving alphabetical order)Background
I just released a new plugin today,
tox-pin-deps
, and hit #2373 while trying to get it working on tox4.