-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing config directory without filename #2550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
v4/conf-dir
branch
from
November 26, 2022 18:02
c356ecf
to
18b3fb0
Compare
gaborbernat
requested changes
Nov 26, 2022
ssbarnea
force-pushed
the
v4/conf-dir
branch
2 times, most recently
from
November 27, 2022 15:53
604eaac
to
9f2f1c5
Compare
ssbarnea
force-pushed
the
v4/conf-dir
branch
from
November 27, 2022 16:54
9f2f1c5
to
fdd5fd4
Compare
ssbarnea
changed the title
Allow call with -c folder
Allow passing config directory without filename
Nov 27, 2022
gaborbernat
requested changes
Nov 27, 2022
ssbarnea
force-pushed
the
v4/conf-dir
branch
from
November 27, 2022 18:28
fdd5fd4
to
9234349
Compare
gaborbernat
reviewed
Nov 27, 2022
ssbarnea
force-pushed
the
v4/conf-dir
branch
from
November 27, 2022 18:32
9234349
to
ca9e83a
Compare
gaborbernat
reviewed
Nov 27, 2022
ssbarnea
force-pushed
the
v4/conf-dir
branch
2 times, most recently
from
November 27, 2022 18:51
eaa38bf
to
c1c419b
Compare
ssbarnea
force-pushed
the
v4/conf-dir
branch
from
November 27, 2022 18:54
c1c419b
to
e4a8e77
Compare
gaborbernat
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2340
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
-- by :user:`<your username>`.
CONTRIBUTORS
(preserving alphabetical order)