Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing config directory without filename #2550

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 26, 2022

Fixes: #2340

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Nov 26, 2022
docs/changelog/2340.bugfix.rst Outdated Show resolved Hide resolved
src/tox/config/source/discover.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea force-pushed the v4/conf-dir branch 2 times, most recently from 604eaac to 9f2f1c5 Compare November 27, 2022 15:53
@ssbarnea ssbarnea marked this pull request as ready for review November 27, 2022 16:52
@ssbarnea ssbarnea changed the title Allow call with -c folder Allow passing config directory without filename Nov 27, 2022
src/tox/config/source/discover.py Outdated Show resolved Hide resolved
tests/config/cli/test_cli_ini.py Outdated Show resolved Hide resolved
tests/config/cli/test_cli_ini.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea force-pushed the v4/conf-dir branch 2 times, most recently from eaa38bf to c1c419b Compare November 27, 2022 18:51
@gaborbernat gaborbernat merged commit 791faea into tox-dev:rewrite Nov 27, 2022
@gaborbernat gaborbernat added this to the 4.0 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided bug:minor does not affect many people or has no big impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants