fix assertions in test_graph to actually test results #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
approved these changes
Jan 29, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Feb 14, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.4.2` -> `4.4.3` | `4.4.5` (+1) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.4.3`](https://togithub.com/tox-dev/tox/releases/tag/4.4.3) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.2...4.4.3) #### What's Changed - \[changelog.rst] typo fix by [@​sparkiegeek](https://togithub.com/sparkiegeek) in [tox-dev/tox#2900 - Support recursive extras defined in pyproject.toml by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2905 - fix assertions in test_graph to actually test results by [@​asottile](https://togithub.com/asottile) in [tox-dev/tox#2906 - Avoid `pre-commit` `isort` crash by [@​gschaffner](https://togithub.com/gschaffner) in [tox-dev/tox#2908 - docs/faq.rst: clarify how constrain_package_deps works by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2902 #### New Contributors - [@​sparkiegeek](https://togithub.com/sparkiegeek) made their first contribution in [tox-dev/tox#2900 - [@​gschaffner](https://togithub.com/gschaffner) made their first contribution in [tox-dev/tox#2908 **Full Changelog**: tox-dev/tox@4.4.2...4.4.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this as an example in an upcoming video -- the current code doesn't properly validate the exception messages for two reasons (1) the
|character allows it to unintentionally match a substring (for exampleraise ValueError("A cycle was detected")passes the test) and (2) thematchargument usesre.searchto find the substring matchpersonally I recommend not using
match=at all and instead assert based on theexcinfoobject -- but this is the minimal "correct" change without annoying the PT011 linter