Ignore labels when provisioning #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the provisioning environment twice, once with the explicit environment and once passing a label (-m)
Do not attempt to set any test environments as active based on user-supplied labels when tox will provision a new environment and re-execute itself. If any labeled environments depend on a future tox version or external plugin, their configuration will be invalid and thus cannot be set active. fix tox-dev#2916
masenf
force-pushed
the
provision-w-label
branch
from
c9aa074
to
386dad4
Compare
gaborbernat
reviewed
Feb 8, 2023
gaborbernat
approved these changes
Feb 8, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Feb 22, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.4.4` -> `4.4.5` | `4.4.6` | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.4.5`](https://togithub.com/tox-dev/tox/releases/tag/4.4.5) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.4...4.4.5) #### What's Changed - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2913 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2914 - Ignore labels when provisioning by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2917 **Full Changelog**: tox-dev/tox@4.4.4...4.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contribution
Ignore labels when tox will provision a runtime environment (
.tox) so that environment configurations which depend on provisioned plugins or specific tox versions are not accessed in the outer tox process where the configuration would be invalid.Extend existing
test_provision_plugin_runnerto also run using labels, which catches this regression.Fix #2916
tox -e fix)docs/changelogfolder