Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#466 stop env var leakage if popen failed with resultjson or redirect #626

Merged
merged 1 commit into from Sep 10, 2017
Merged

#466 stop env var leakage if popen failed with resultjson or redirect #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions tox/session.py
View file
Open in desktop
Expand Up @@ -122,8 +122,7 @@ def popen(self, args, cwd=None, env=None, redirect=True, returnout=False, ignore
resultjson = self.session.config.option.resultjson
if resultjson or redirect:
fout = self._initlogpath(self.id)
fout.write("actionid: %s\nmsg: %s\ncmdargs: %r\nenv: %s\n\n" % (
self.id, self.msg, args, env))
fout.write("actionid: %s\nmsg: %s\ncmdargs: %r\n\n" % (self.id, self.msg, args))
fout.flush()
self.popen_outpath = outpath = py.path.local(fout.name)
fin = outpath.open()
Expand Down