release 3.1.0a1 #877
release 3.1.0a1 #877
Conversation
gaborbernat
force-pushed
the
release-3.1.0a1
branch
8 times, most recently
from
ea6515d
to
73585a2
Compare
gaborbernat
force-pushed
the
release-3.1.0a1
branch
from
73585a2
to
6c698ad
Compare
| project: yes | ||
| patch: yes | ||
| changes: no | ||
| project: |
There was a problem hiding this comment.
Ok, let's report code coverage, but don't fail on it whatever the value is. The maintainer will make a judgment if the current value is ok or not (this takes care of flaky test reports, or cases when we don't want the CI to run fully - e.g. documentation only changes - AppVeyor).
| @@ -1,3 +1,10 @@ | |||
| if: tag IS present OR type = pull_request OR (branch = master AND type = push) # we only CI the master, tags and PRs | |||
There was a problem hiding this comment.
Build tags, pull requests and pushes on the master branch. Ignore all other.
| stages: | ||
| - test | ||
| - name: deploy | ||
| if: repo = tox-dev/tox AND branch = master AND tag IS present |
There was a problem hiding this comment.
Only deploy when tagging a commit on the master branch. @nicoddemus note this gets evaluated upfront, so you no longer hold up the CI for a no operation deploy on PRs (e.g. fast fail works again).
There was a problem hiding this comment.
Interesting!
About tagging commit on master: I think it would be better to tag the commit at the HEAD on the release PR. This way you guarantee that you are publishing exactly what was tested on the PR.
There was a problem hiding this comment.
pytest-dev/pytest#3666 馃槈 Thanks!
| @@ -64,6 +64,7 @@ before_install: | |||
| install: | |||
| - pip install -U six | |||
| - pip install --pre -U tox | |||
| - tox --notest | |||
There was a problem hiding this comment.
move tox env setup to the setup phase
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 92.49% 91.03% -1.46%
==========================================
Files 12 12
Lines 2331 2331
Branches 408 408
==========================================
- Hits 2156 2122 -34
- Misses 110 142 +32
- Partials 65 67 +2
Continue to review full report at Codecov.
|
馃憤 take two