New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body 元素未加载时出现问题 #3

Closed

yandeqiang opened this issue Jan 15, 2018 · 0 comments

Assignees

Labels

bug help wanted

yandeqiang commented Jan 15, 2018

https://github.com/toxic-johann/es-fullscreen/blob/master/src/index.js#L22

js 代码全部都放在，head 标签里的时候，可能 body标签都没有加载出来，就去执行这句，然后找不到 body 了
建议使用 document.documentElement

toxic-johann self-assigned this

toxic-johann added bug help wanted labels

toxic-johann referenced this issue


          [fix] use document.documentElement as backup when there is no documen…

02ff169

…t.body

why: if user include our library in the head, they may cause error as there is no document.body
fix[https://github.com/toxic-johann/es-fullscreen/issues/3](https://github.com/toxic-johann/es-fullscreen/issues/3)

toxic-johann closed this as completed in

117ee72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment