Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to cache results? #83

Closed
toy opened this issue Mar 18, 2015 · 6 comments
Closed

Add option to cache results? #83

toy opened this issue Mar 18, 2015 · 6 comments

Comments

@toy
Copy link
Owner

toy commented Mar 18, 2015

--cache=dir/cache: 'dir'
Save result of optimization by src digest + options digest

@toy toy mentioned this issue Mar 18, 2015
@tejasmanohar
Copy link

+1

@gpakosz
Copy link
Contributor

gpakosz commented Apr 16, 2015

Well, I believe you would need: src image digest + options digest + binaries digest to make sure upgrading binaries triggers cache eviction.

Much looking forward to see that feature!

@toy
Copy link
Owner Author

toy commented Apr 19, 2015

@gpakosz Using binaries digest depends on the assumption about the purpose of cache: without binaries digest, cache will be an efficient time saver and with binaries digest it may become much less efficient, though will probably save few or more bytes from time to time.

@gpakosz
Copy link
Contributor

gpakosz commented Apr 19, 2015

@toy well it's a matter of reproducibility I would say: an optimize image is the product of source image + optimizers versions + options. I would argue binaries deployed change rarely balancing your "much less efficient" point of view.

@toy
Copy link
Owner Author

toy commented Apr 19, 2015

@gpakosz It will be often if binaries will be updated regularly — check https://github.com/toy/image_optim_pack/releases. Also cache can be removed manually. And caching can have an option to switch on/off binaries digest.

@gpakosz
Copy link
Contributor

gpakosz commented Apr 19, 2015

An option to cache upon binaries digest is indeed a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants