-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to cache results? #83
Comments
+1 |
Well, I believe you would need: src image digest + options digest + binaries digest to make sure upgrading binaries triggers cache eviction. Much looking forward to see that feature! |
@gpakosz Using binaries digest depends on the assumption about the purpose of cache: without binaries digest, cache will be an efficient time saver and with binaries digest it may become much less efficient, though will probably save few or more bytes from time to time. |
@toy well it's a matter of reproducibility I would say: an optimize image is the product of source image + optimizers versions + options. I would argue binaries deployed change rarely balancing your "much less efficient" point of view. |
@gpakosz It will be often if binaries will be updated regularly — check https://github.com/toy/image_optim_pack/releases. Also cache can be removed manually. And caching can have an option to switch on/off binaries digest. |
An option to cache upon binaries digest is indeed a good idea |
--cache=dir
/cache: 'dir'
Save result of optimization by src digest + options digest
The text was updated successfully, but these errors were encountered: