Allow svgo plugins to be disabled #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis CI build failure seems to be a false positive. |
| @@ -4,11 +4,17 @@ class ImageOptim | |||
| class Worker | |||
| # https://github.com/svg/svgo | |||
| class Svgo < Worker | |||
| DISABLE_PLUGINS_OPTION = | |||
| option(:disable_plugins, [], Array, 'List of plugins to disable'){ |v| v } | |||
There was a problem hiding this comment.
No need to provide Array as an argument as type will be guessed from [].
Better to use Array(v).map(&:to_s) in the proc to have no problems with single values and arrays with non string values.
|
Great! @Firefishy Yep, a bug in rubocop, resolved on master |
tomhughes
force-pushed
the
svgo
branch
3 times, most recently
from
1e70fa8
to
7b2775f
Compare
|
Hopefully that should be all your comments addressed now. |
Adds :disable_plugins and :enable_plugins options to the svgo worker.
|
Thanks, merged 8d534db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.