Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for use as pre-commit hook #192

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Add support for use as pre-commit hook #192

merged 1 commit into from
Apr 18, 2021

Conversation

proinsias
Copy link
Contributor

@proinsias proinsias commented Apr 9, 2021

  • Adds configuration files needed for image_optim to be used as pre-commit.com hook.
  • Also adds GitHub Action to regularly run pre-commit autoupdate and create a pull request to update hook versions if needed.

Copy link
Owner

@toy toy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Unfortunately looks like the action failed.
Could you also please describe what is the action supposed to do? Check if version is up to date with what pre-commit knows as the latest version?

.pre-commit-hooks.yaml Outdated Show resolved Hide resolved
CHANGELOG.markdown Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
@proinsias
Copy link
Contributor Author

@toy – thanks for the review. I believe I've addressed your comments. I realized I didn't need the GitHub Action as you're not using pre-commit for this repo itself.

@toy
Copy link
Owner

toy commented Apr 18, 2021

Thanks for finishing the PR :)
Travis is failing only because failing check on up to date rubies.
Seemed to work when installing from your fork and specifying commit sha for rev, do I understand right that it would be better to create a release (tag) for it to work nicely?

@toy toy merged commit 77efa94 into toy:master Apr 18, 2021
@proinsias
Copy link
Contributor Author

Thanks! And yes a release tag would be great.

@proinsias proinsias deleted the proinsias-add-support-for-pre-commit-hook branch April 19, 2021 15:44
@toy
Copy link
Owner

toy commented Apr 28, 2021

Created v0.29.0 tag

@toy toy mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants