Updated code flagged by static analysis.

toy · Aug 30, 2009 · 32d5ce8 · 32d5ce8
1 parent 135df34
commit 32d5ce8
Show file tree

Hide file tree

Showing 7 changed files with 1,293 additions and 1,006 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,5 @@
 build
+*.mode1v3
 *.pbxuser
 *.perspectivev3
 .DS_Store
diff --git a/DPGrowl.m b/DPGrowl.m
@@ -28,7 +28,7 @@ + (id)alloc
 
 - (void)initializeGrowl
 {
-	[GrowlApplicationBridge setGrowlDelegate:@""];
+	[GrowlApplicationBridge setGrowlDelegate:self];
 }
 
 - (void)showGrowlNotification:(NSString *)growlName:(NSString *)growlTitle:(NSString *)growlDescription

diff --git a/DPLoginItem.m b/DPLoginItem.m
@@ -53,6 +53,7 @@ + (void)addToLoginItems
 	NSString *script = [NSString stringWithFormat:@"set appPath to \"%@\" \ntell application \"System Events\" \nmake login item at end with properties {path:appPath, hidden:false} \nend tell", fullPath];
 	NSAppleScript *appleScript = [[NSAppleScript alloc] initWithSource:script];
 	[appleScript executeAndReturnError:nil];
+	[appleScript release];
 }
 
 @end
diff --git a/ISI_LoginItemView.xib b/ISI_LoginItemView.xib
diff --git a/ISI_Menus.xib b/ISI_Menus.xib
diff --git a/ISI_MenusController.m b/ISI_MenusController.m
@@ -62,13 +62,15 @@ - (IBAction)doSendFile:(id)sender
 	NSString *sendFilesString = @"tell application \"Bluetooth File Exchange\"\r activate\r end tell";
 	NSAppleScript *sendFilesScript = [[NSAppleScript alloc] initWithSource:sendFilesString];
 	[sendFilesScript executeAndReturnError:nil];
+	[sendFilesScript release];
 }
 
 - (IBAction)doSetUpDevice:(id)sender
 {
 	NSString *setDeviceString = @"tell application \"Bluetooth Setup Assistant\"\r activate\r end tell";
 	NSAppleScript *setDeviceScript = [[NSAppleScript alloc] initWithSource:setDeviceString];
 	[setDeviceScript executeAndReturnError:nil];
+	[setDeviceScript release];
 }
 
 - (IBAction)turnBluetoothOn:(id)sender
@@ -82,6 +84,7 @@ - (IBAction)showChangeLog:(id)sender
 	[NSApp activateIgnoringOtherApps:YES];
 	ISI_WindowController *changeLogWindow = [[ISI_WindowController alloc] initWithWindowNibName:@"ISI_ChangeLog"];
 	[changeLogWindow showWindow:self];
+	[changeLogWindow release];
 }
 
 - (IBAction)showPreferences:(id)sender

diff --git a/ISI_Sync.m b/ISI_Sync.m
@@ -18,7 +18,7 @@ + (void)startSync:(BOOL)defaultsValue
 	[defaults setObject:[NSDate date] forKey:@"ISI_LastSync"];
 	[[NSUserDefaults standardUserDefaults] synchronize];
 
-	int currentStatus;
+	int currentStatus = 0;
 
 	if ([ISI_Bluetooth available]) {
 		if (defaultsValue == TRUE) {
@@ -32,6 +32,7 @@ + (void)startSync:(BOOL)defaultsValue
 	NSString *syncNowString = @"tell application \"iSync\"\r if not (synchronize) then\r else\r repeat while (syncing is true)\r delay 5\r end repeat\r quit\r end if\r end tell";
 	NSAppleScript *syncNowScript = [[NSAppleScript alloc] initWithSource:syncNowString];
 	[syncNowScript executeAndReturnError:nil];
+	[syncNowScript release];
 
 	if ([ISI_Bluetooth available]) {
 		if (defaultsValue == TRUE) {