Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppo2 doesn't like something on amidar #15

Closed
etosch opened this issue Sep 16, 2018 · 1 comment
Closed

ppo2 doesn't like something on amidar #15

etosch opened this issue Sep 16, 2018 · 1 comment

Comments

@etosch
Copy link
Collaborator

etosch commented Sep 16, 2018

Running with with the ppo2 algorithm causes a silent failure. Not sure why.
etosch added a commit that referenced this issue Sep 16, 2018
@etosch
trying to figure out #15
96ffad0
jjfiv added a commit that referenced this issue Sep 16, 2018
@jjfiv
Amidar zero lives bug fixes root of #15, unblocks #13,#14
097dbbc
@jjfiv
Copy link
Collaborator

jjfiv commented Sep 16, 2018

This was actually a bug in self.lives on Amidar; I had moved it to reset(), being clever, but apparently didn't test. Since reset() is called in the "constructor" of State, starting with just 1 life meant you actually started with zero. Moved the self.lives--; to where if dead happens.

@jjfiv jjfiv closed this as completed Sep 16, 2018
jjfiv added a commit that referenced this issue Sep 25, 2018
@jjfiv
Fix bug in lives #23 #20 #15
8fe30fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etosch @jjfiv