Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring idea: separate game types that are exposed in JSON to a types.rs per game #77

Closed
jjfiv opened this issue Feb 22, 2019 · 0 comments
Closed

Refactoring idea: separate game types that are exposed in JSON to a types.rs per game #77

jjfiv opened this issue Feb 22, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers rust This should probably be solved in Rust.
Milestone
Public Release

Comments

@jjfiv
Copy link
Collaborator

jjfiv commented Feb 22, 2019

This way folks less familiar with Rust but interested in the JSON can look at the data separate from the code. It might be a logical way to break up our otherwise monolith games.
@jjfiv jjfiv added enhancement New feature or request rust This should probably be solved in Rust. labels Feb 22, 2019
@jjfiv jjfiv added the good first issue Good for newcomers label Apr 12, 2019
@jjfiv jjfiv added this to the Public Release milestone Apr 12, 2019
jjfiv added a commit that referenced this issue Apr 13, 2019
@jjfiv
split breakout types and document all fields for state and config #77
793e6e7
jjfiv added a commit that referenced this issue Apr 13, 2019
@jjfiv
rustdoc for breakout in progress #77
6960037
jjfiv added a commit that referenced this issue Apr 13, 2019
@jjfiv
make more things public for better rustdoc #77
1566827
jjfiv added a commit that referenced this issue Apr 14, 2019
@jjfiv
refactor and comment types for space-invaders #77
959d3cc
jjfiv added a commit that referenced this issue Apr 14, 2019
@jjfiv
split breakout types and document all fields for state and config #77
7630f3b
jjfiv added a commit that referenced this issue Apr 14, 2019
@jjfiv
rustdoc for breakout in progress #77
f285201
jjfiv added a commit that referenced this issue Apr 14, 2019
@jjfiv
make more things public for better rustdoc #77
a09755c
jjfiv added a commit that referenced this issue Apr 14, 2019
@jjfiv
refactor and comment types for space-invaders #77
a3d1400
etosch added a commit that referenced this issue Apr 20, 2019
@etosch
Merge pull request #101 from jjfiv/separate-types
e1078f9 
Separate types (based on issue #77)
@etosch etosch closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers rust This should probably be solved in Rust.
Projects
None yet
Milestone
Public Release
Development

No branches or pull requests
2 participants
@etosch @jjfiv