Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize (gridworld) after board/grid changes in config #82

Closed
kclary opened this issue Mar 8, 2019 · 1 comment
Closed

Resize (gridworld) after board/grid changes in config #82

kclary opened this issue Mar 8, 2019 · 1 comment
Labels
gridworld rust This should probably be solved in Rust.

Comments

@kclary
Copy link
Collaborator

kclary commented Mar 8, 2019

When the Gridworld grid is altered in config, the window should auto-resize during human_play. Not sure if this is a problem outside of human_play.

@jjfiv
Copy link
Collaborator

jjfiv commented Mar 8, 2019

This is a config-ish bug.

Here we trust the size stored on config rather than calculate it from the board:
https://github.com/jjfiv/toybox/blob/interventions/tb_gridworld/src/gridworld.rs#L182

I propose we sync it with the state impl:
https://github.com/jjfiv/toybox/blob/interventions/tb_gridworld/src/gridworld.rs#L116-L119

And delete game_size from the config. It's implicit.
https://github.com/jjfiv/toybox/blob/interventions/tb_gridworld/src/gridworld.rs#L64

@jjfiv jjfiv added rust This should probably be solved in Rust. gridworld labels Mar 8, 2019
@jjfiv jjfiv changed the title Resize (gridworld) after boad/grid changes in config Resize (gridworld) after board/grid changes in config Mar 14, 2019
jjfiv added a commit that referenced this issue Mar 15, 2019
jjfiv added a commit that referenced this issue Mar 15, 2019
etosch added a commit that referenced this issue Mar 16, 2019
Gridworld and arbitrary-sized envs (#82)
jjfiv added a commit that referenced this issue Mar 22, 2019
@jjfiv jjfiv closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gridworld rust This should probably be solved in Rust.
Projects
None yet
Development

No branches or pull requests

2 participants