Support for Hapi v17 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated dependencies. Fixed issue with server.connections used for route iteration before. * Partial fix for the tests. * Made logic around ACL queries asynchronous. Fixed part of tests. * Fixed remaining errors and tests. * Updated README
Closed
|
@toymachiner62 I've tested it with my use-case and no issue. |
| - '5' | ||
| - '4.2.0' | ||
| - '4' | ||
| - 8 |
There was a problem hiding this comment.
Any reason we're skipping node 9?
There was a problem hiding this comment.
I took it from hapijs, I guess they only officially support LTS
toymachiner62
approved these changes
Sep 10, 2018
|
Available on npm version 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 17.x only supports node v8.9.0 and over.)vartolet/constregistersyntax for pluginsqto use native promiserolestoaclQueryifroleis undefinedThx @maxaus for his contribution.
I recommend having more people testing it.
just modify your
package.jsonfrom"hapi-authorization": "^3.0.2",to
"hapi-authorization": "mycshq/hapi-authorization#hapi-17",and run
npm i