Fix to see content-type of error response #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidz
requested changes
Nov 13, 2019
There was a problem hiding this comment.
@makinoshi format-err looks good to me 👍
Please add tests to check whether response body is parsed as JSON or not by Content-Type header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kintone API sometimes returns HTML response, for example basic authentication fails.
So this PR changes error handing to see
Content-Typeand parse body only when it isapplication/json.This PR makes
kintone-cljreturn following response when basic authentication fails.#kintone.types.KintoneResponse{:res nil, :err {:status 401, :status-text "401", :response "<!DOCTYPE html>\r <html>\r <head>\r <meta charset=\"utf-8\">\r <title>Unauthorized</title>\r <meta name=\"viewport\" content=\"width=device-width,initial-scale=1\">\r <link rel=\"stylesheet\" href=\"/forest_error/css/style.css\">\r </head>\r \r <body>\r <div class=\"pagewrap\">\r <div class=\"column\"> <img src=\"/forest_error/image/cloud.png\" width=\"178\" height=\"107\" alt=\"\">\r <h2>アクセスするには認証が必要です。</h2>\r <p>Code: 401 Unauthorized</p>\r </div>\r </div>\r <div class=\"footer\">\r <p>Copyright(C) Cybozu</p>\r </div>\r </body>\r </html>\r "}}