Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run npm audit fix #15

Merged
merged 1 commit into from
May 25, 2020
Merged

run npm audit fix #15

merged 1 commit into from
May 25, 2020

Conversation

saitouena
Copy link
Contributor

run npm audit fix to bump vulnerable libraries .

$ npm audit fix
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.11 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.11: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

removed 1 package in 3.079s

17 packages are looking for funding
  run `npm fund` for details

fixed 543 of 832 vulnerabilities in 632 scanned packages
  2 package updates for 289 vulnerabilities involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)

$ npm audit fix
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.11 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.11: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

removed 1 package in 3.079s

17 packages are looking for funding
  run `npm fund` for details

fixed 543 of 832 vulnerabilities in 632 scanned packages
  2 package updates for 289 vulnerabilities involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)
@saitouena saitouena requested a review from egs33 May 25, 2020 03:00
@@ -1,6 +1,6 @@
{
"name": "kintone-query-builder",
"version": "0.1.0",
"version": "0.1.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited package.json manually without running npm version command, so package-lock.json was specifying 0.1.0.
npm audit fix fixes this inconsistency.

Copy link
Member

@egs33 egs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saitouena
Copy link
Contributor Author

Thanks!

@saitouena saitouena merged commit f6cda6a into master May 25, 2020
@saitouena saitouena deleted the npm-audit-fix branch May 25, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants