Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm publish using circleci #19

Merged
merged 7 commits into from
Nov 5, 2020
Merged

Npm publish using circleci #19

merged 7 commits into from
Nov 5, 2020

Conversation

saitouena
Copy link
Contributor

@saitouena saitouena commented Nov 4, 2020

I added circleci workflow setting to publish this package with tagged commits.
https://circleci.com/blog/tips-for-optimizing-docker-builds/

The changes of #18 got unnecessary anymore so it was reverted.

@saitouena saitouena marked this pull request as ready for review November 5, 2020 03:44
@saitouena saitouena requested a review from egs33 November 5, 2020 03:44
Copy link
Member

@egs33 egs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@saitouena
Copy link
Contributor Author

Thanks!

@saitouena saitouena merged commit f506f6c into master Nov 5, 2020
@saitouena saitouena deleted the npm-publish-using-circleci branch November 5, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants