test for invalid username

client.go

@@ -1961,6 +1961,9 @@ func (c *ToznySDKV3) ListSecrets(ctx context.Context, options ListSecretsOptions
 				if err != nil {
 					return nil, err
 				}
+				if len(identities.SearchedIdentitiesInformation) < 1 {
+					return nil, fmt.Errorf("ListSecrets: no identity found with clientID %s", record.Metadata.WriterID)
+				}
 				username := identities.SearchedIdentitiesInformation[0].RealmUsername
 				record.Metadata.Plain[SecretWriterUsernameMetadataKey] = username
 				record.Metadata.Plain[SecretSharedMetadataKey] = shared
@@ -2104,6 +2107,9 @@ func (c *ToznySDKV3) ShareSecretWithUsername(ctx context.Context, params ShareSe
 	if err != nil {
 		return err
 	}
+	if len(identities.SearchedIdentitiesInformation) < 1 {
+		return fmt.Errorf("ShareSecretWithUser: no identity found with username %s", params.UsernameToAdd)
+	}
 	// find or create the group for sharing with UsernameToAdd
 	namespaceOptions := NamespaceOptions{
 		RealmName: c.CurrentIdentity.Realm,

secrets_test.go

@@ -286,6 +286,38 @@ func TestShareSecretByUsernameSucceeds(t *testing.T) {
 	}
 }
 
+func TestShareSecretInvalidUsernameFails(t *testing.T) {
+	request := TozIDLoginRequest{
+		Username:     username,
+		Password:     password,
+		RealmName:    realmName,
+		APIBaseURL:   baseURL,
+		LoginHandler: mfaHandler,
+	}
+	sdk, err := GetSDKV3ForTozIDUser(request)
+	if err != nil {
+		t.Fatalf("Could not log in %+v", err)
+	}
+	viewOptions := ViewSecretOptions{
+		SecretID:   uuid.MustParse(secret1ID),
+		MaxSecrets: 1000,
+	}
+	secret, err := sdk.ViewSecret(testCtx, viewOptions)
+	if err != nil {
+		t.Fatalf("Error viewing shared secret: Err: %+v", err)
+	}
+	// share secret with a username that doesn't exist
+	shareOptions := ShareSecretInfo{
+		SecretName:    secret.SecretName,
+		SecretType:    secret.SecretType,
+		UsernameToAdd: "invalid-user",
+	}
+	err = sdk.ShareSecretWithUsername(testCtx, shareOptions)
+	if err == nil {
+		t.Fatal("Should error since username doesn't exist\n")
+	}
+}
+
 func mfaHandler(sessionResponse *IdentitySessionIntermediateResponse) (LoginActionData, error) {
 	if sessionResponse.LoginActionType == "login-totp" {
 		totpValue := make(map[string]string)