Optimistic Locking Support; SDK Parity #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records can only be created via the Write method; removed the NewRecord method.
m4dc4p
force-pushed
the
jgbailey/optimistic-locking
branch
from
156a2d6
to
dc0f45d
Compare
ericmann
approved these changes
Jun 5, 2017
client.go
Outdated
| @@ -77,6 +77,7 @@ type Meta struct { | |||
| Plain map[string]string `json:"plain"` | |||
| Created time.Time `json:"created"` | |||
| LastModified time.Time `json:"last_modified"` | |||
| Version string `json:"version,omitempty"` | |||
There was a problem hiding this comment.
gofmt ... please align struct definitions.
jamesjb
approved these changes
Jun 7, 2017
client.go
Outdated
| return &Record{ | ||
| // Write writes a new encrypted record to the database. Returns the new record (with | ||
| // the original, unencrypted data) | ||
| func (c *Client) Write(ctx context.Context, recordType string, data *map[string]string, plain *map[string]string) (*Record, error) { |
There was a problem hiding this comment.
I don't think you need to pass pointers to maps here, since maps are already reference types:
func (c *Client) Write(ctx context.Context, recordType string, data, plain map[string]string) (*Record, error)
You can still pass nil as a map[string]string, like you would with an error.
client.go
Outdated
| } else { | ||
| plainMap = *plain | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this can go away if plain becomes a map[string]string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionheader to Meta structure, to support safe update endpoint.Updatemethod to clientWriteso it creates a record (similar to Ruby SDK). RemovedNewRecordas it's no longer necessary.2.0.0-rc1.