README doc updates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
requested review from
lkwdwrd,
fernviridian,
efabens and
jennatuckerdeveloper
1 similar comment
lkwdwrd
approved these changes
Nov 15, 2018
efabens
approved these changes
Nov 15, 2018
|
@lkwdwrd Not sure why that build failed either and the other passed, doesn't look to be anything branch specific - the build that failed was @go1.8, whereas the other one that passed was at go1.7 , looks like it was trying to run the integration tests, got to trying to test the Event api, and then spun for 10s waiting for the events it posted to become visible. Is it okay if I merge this or do you want me to get that build passing(@tgjamin is there a way I can manually retrigger the failed build to see if it was an intermittent issue with the integration environment?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README's Reading and Writing Records section for latest version of the SDK.