Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 3rd party login functionality to retrieve a V3SDK #56

Merged
merged 5 commits into from
May 3, 2021

Conversation

efabens
Copy link
Contributor

@efabens efabens commented Apr 14, 2021

  • Supports arbitrary action handler functions
  • Example mfa function in identity_test
  • Broker login
  • More tests to come

@coveralls
Copy link

coveralls commented Apr 14, 2021

Coverage Status

Coverage decreased (-1.6%) to 27.696% when pulling 3553dd0 on feature-instantiate-client-tozid into 9c01156 on master.

@efabens efabens force-pushed the feature-instantiate-client-tozid branch from 1f939cd to 4d41d55 Compare April 26, 2021 21:06
- Supports arbitrary action handler functions
- Example mfa function in identity_test
- More tests to come
@efabens efabens force-pushed the feature-instantiate-client-tozid branch from 4d41d55 to 7e3d284 Compare April 26, 2021 21:10
@efabens efabens force-pushed the feature-instantiate-client-tozid branch 2 times, most recently from d4db273 to a25bf4b Compare April 28, 2021 15:31
@efabens efabens force-pushed the feature-instantiate-client-tozid branch 4 times, most recently from fb65686 to cb9782d Compare April 28, 2021 21:07
@efabens efabens marked this pull request as ready for review April 28, 2021 21:28
@efabens efabens force-pushed the feature-instantiate-client-tozid branch from cb9782d to 598f050 Compare April 28, 2021 21:55
@efabens efabens changed the title WIP: Adds 3rd party login functionality to retrieve a V3SDK Adds 3rd party login functionality to retrieve a V3SDK Apr 28, 2021
client.go Outdated
Username string
Password string
RealmName string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Host: login.APIBaseURL,
AuthNHost: login.APIBaseURL,
}
ctx := context.Background()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be global?

@efabens efabens force-pushed the feature-instantiate-client-tozid branch 2 times, most recently from 4f4989e to e011a65 Compare April 30, 2021 20:36
@efabens efabens force-pushed the feature-instantiate-client-tozid branch from e011a65 to 3553dd0 Compare May 3, 2021 21:51
@efabens efabens merged commit 3553dd0 into master May 3, 2021
@efabens efabens deleted the feature-instantiate-client-tozid branch May 3, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants