-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 3rd party login functionality to retrieve a V3SDK #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
efabens
commented
Apr 14, 2021
- Supports arbitrary action handler functions
- Example mfa function in identity_test
- Broker login
- More tests to come
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
from
April 26, 2021 21:06
1f939cd
to
4d41d55
Compare
- Supports arbitrary action handler functions - Example mfa function in identity_test - More tests to come
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
from
April 26, 2021 21:10
4d41d55
to
7e3d284
Compare
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
2 times, most recently
from
April 28, 2021 15:31
d4db273
to
a25bf4b
Compare
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
4 times, most recently
from
April 28, 2021 21:07
fb65686
to
cb9782d
Compare
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
from
April 28, 2021 21:55
cb9782d
to
598f050
Compare
efabens
changed the title
WIP: Adds 3rd party login functionality to retrieve a V3SDK
Adds 3rd party login functionality to retrieve a V3SDK
Apr 28, 2021
rosasck
approved these changes
Apr 29, 2021
client.go
Outdated
Username string | ||
Password string | ||
RealmName string | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space
Host: login.APIBaseURL, | ||
AuthNHost: login.APIBaseURL, | ||
} | ||
ctx := context.Background() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be global?
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
2 times, most recently
from
April 30, 2021 20:36
4f4989e
to
e011a65
Compare
efabens
force-pushed
the
feature-instantiate-client-tozid
branch
from
May 3, 2021 21:51
e011a65
to
3553dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.