Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read file support #58

Merged
merged 4 commits into from
May 10, 2021
Merged

Read file support #58

merged 4 commits into from
May 10, 2021

Conversation

carrala
Copy link
Contributor

@carrala carrala commented May 7, 2021

Support for downloading and decrypting a file from a record.

@coveralls
Copy link

Coverage Status

Coverage decreased (-41.2%) to 0.0% when pulling f6bb326 on download-file-support into 11ca5dc on master.

@coveralls
Copy link

coveralls commented May 7, 2021 •
edited

Coverage Status

Coverage increased (+0.5%) to 41.914% when pulling 60e94de on download-file-support into 38ad962 on master.

efabens
efabens reviewed May 8, 2021
View reviewed changes
client.go Show resolved Hide resolved
efabens
efabens reviewed May 8, 2021
View reviewed changes
Copy link
Contributor

@efabens efabens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the use of options. A few concerns about concurrent file-system access

galxy25
galxy25 reviewed May 8, 2021
View reviewed changes
client.go Show resolved Hide resolved
galxy25
galxy25 reviewed May 8, 2021
View reviewed changes
client.go Outdated Show resolved Hide resolved
galxy25
galxy25 reviewed May 8, 2021
View reviewed changes
client.go Outdated Show resolved Hide resolved
galxy25
galxy25 reviewed May 8, 2021
View reviewed changes
client.go Show resolved Hide resolved
galxy25
galxy25 reviewed May 8, 2021
View reviewed changes
client.go Outdated Show resolved Hide resolved
galxy25
galxy25 approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@galxy25 galxy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending resolution of comments

@carrala carrala requested a review from efabens May 10, 2021 23:08
@carrala carrala merged commit b811f8c into master May 10, 2021
@carrala carrala deleted the download-file-support branch May 10, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efabens efabens efabens approved these changes

@galxy25 galxy25 galxy25 approved these changes

@lkwdwrd lkwdwrd Awaiting requested review from lkwdwrd

@rosasck rosasck Awaiting requested review from rosasck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carrala @coveralls @efabens @galxy25