Share secrets by username #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efabens
reviewed
May 17, 2021
efabens
reviewed
May 17, 2021
efabens
reviewed
May 17, 2021
efabens
reviewed
May 17, 2021
galxy25
reviewed
May 18, 2021
|
Changes:
|
galxy25
reviewed
May 18, 2021
client.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ownerClientID, err := uuid.Parse(c.StorageClient.ClientID) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
remember that a key reason for this change is to return an informative error message, suggest
return nil, errors.New(fmt.Sprintf("CreateSecret: Client ID must be a valid UUID, got %s", c.StorageClient.ClientID))There was a problem hiding this comment.
got it! will update these error messages throughout.
galxy25
approved these changes
May 18, 2021
efabens
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share secrets with identities by username, with a test.
DecryptTextSecret was updated to use the group eak, so that it can decrypt secrets that are owned or shared with the identity.