Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a secret #63

Merged
merged 21 commits into from
May 24, 2021
Merged

Delete a secret #63

merged 21 commits into from
May 24, 2021

Conversation

carrala
Copy link
Contributor

@carrala carrala commented May 24, 2021

  • DeleteSecret unshares the secret with secretID from every group it's shared to & then deletes the secret.

galxy25
galxy25 reviewed May 24, 2021
View reviewed changes
client.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 24, 2021 •
edited

Coverage Status

Coverage increased (+1.1%) to 46.296% when pulling f3222b8 on delete-secret into 1fe9d72 on master.

@carrala carrala merged commit 767a146 into master May 24, 2021
@carrala carrala deleted the delete-secret branch May 24, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efabens efabens efabens approved these changes

@galxy25 galxy25 galxy25 approved these changes

@Mrhea Mrhea Awaiting requested review from Mrhea

@rosasck rosasck Awaiting requested review from rosasck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carrala @coveralls @efabens @galxy25