[OPS-901] Fix Secrets Versioning #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
efabens
commented
Aug 3, 2021
efabens
commented
- Secret version should be unix milli but was timestamp
efabens
requested review from
carrala,
galxy25,
Mrhea,
pirtleshell,
rosasck and
sjonz
efabens
force-pushed
the
ops-901-secret-version-fix
branch
from
85cefd7
to
f3a5feb
Compare
galxy25
approved these changes
Aug 3, 2021
efabens
force-pushed
the
ops-901-secret-version-fix
branch
from
f3a5feb
to
c0d6989
Compare
- Secret version should be unix milli but was timestamp - Secret file-name updated to be exclusively filename and not path
efabens
force-pushed
the
ops-901-secret-version-fix
branch
from
c0d6989
to
bece743
Compare
pirtleshell
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.