Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests run and swap out 64 encoding to use the base64url node lib #13

Merged
merged 1 commit into from Nov 27, 2018
Merged

Make tests run and swap out 64 encoding to use the base64url node lib #13

merged 1 commit into from Nov 27, 2018

Conversation

lkwdwrd
Copy link
Contributor

@lkwdwrd lkwdwrd commented Nov 27, 2018

No description provided.

eddier
eddier approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@eddier eddier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 82.321% when pulling f7d9915 on fix/b64-mem-leak into 9eff449 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 82.321% when pulling f7d9915 on fix/b64-mem-leak into 9eff449 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 82.321% when pulling f7d9915 on fix/b64-mem-leak into 9eff449 on master.

fernviridian
fernviridian approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@fernviridian fernviridian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lkwdwrd lkwdwrd merged commit 296ef81 into master Nov 27, 2018
@lkwdwrd lkwdwrd deleted the fix/b64-mem-leak branch November 27, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddier eddier eddier approved these changes

@fernviridian fernviridian fernviridian approved these changes

@jennatuckerdeveloper jennatuckerdeveloper jennatuckerdeveloper approved these changes

@efabens efabens Awaiting requested review from efabens

@galxy25 galxy25 Awaiting requested review from galxy25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lkwdwrd @coveralls @eddier @fernviridian @jennatuckerdeveloper