Authorizer support to PHP #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernviridian
suggested changes
Feb 1, 2019
php/Client.php
Outdated
|
|
||
| $allow = new \stdClass(); | ||
| $allow->allow = [['read' => new \stdClass()]]; | ||
| $path = $this->conn->uri('v1', 'storage', 'policy',$writer_id, $writer_id, $reader_id, $record_type); |
php/Client.php
Outdated
| } catch (RequestException $re) { | ||
| throw new NotFoundException("Could not retrieve data"); | ||
| } | ||
| return json_decode($resp->getBody()->getContents()); |
There was a problem hiding this comment.
Does the php SDK do anything with types, or is it just throwing decoded json bodies around?
There was a problem hiding this comment.
It is doing types:
https://github.com/tozny/e3db-php/tree/master/php/Types
I agree for consistency this should return a new type rather than a stdClass instance.
galxy25
approved these changes
Feb 1, 2019
lkwdwrd
suggested changes
Feb 4, 2019
php/Client.php
Outdated
| } catch (RequestException $re) { | ||
| throw new NotFoundException("Could not retrieve data"); | ||
| } | ||
| return json_decode($resp->getBody()->getContents()); |
There was a problem hiding this comment.
It is doing types:
https://github.com/tozny/e3db-php/tree/master/php/Types
I agree for consistency this should return a new type rather than a stdClass instance.
fernviridian
approved these changes
Feb 12, 2019
php/Types/AuthorizedBy.php
Outdated
| * All rights reserved. | ||
| * | ||
| * @package Tozny\E3DB | ||
| * @copyright Copyright (c) 2017 Tozny, LLC (https://tozny.com) |
lkwdwrd
approved these changes
Feb 13, 2019
php/Types/AuthorizedBy.php
Outdated
| namespace Tozny\E3DB\Types; | ||
|
|
||
| /** | ||
| * Full nformation about a specific E3DB client, including the client's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for share on behalf of
Support for revoke on behalf of
Support for get authorized by