Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cross-sdk test for Ruby #19

Merged
merged 6 commits into from
Nov 23, 2017
Merged

Add Cross-sdk test for Ruby #19

merged 6 commits into from
Nov 23, 2017

Conversation

fernviridian
Copy link
Contributor

  • Added Dockerfile
  • Added integration.rb file for cross-sdk test

Justin Bailey and others added 5 commits November 17, 2017 15:44
URL Encoding Fixes; Test Updates
30542db 
* Client did not handle missing EAKs correclty - now
  transforms to nil.
* Base64 URL encoding used a method only available in
  Ruby >= 2.3; update for Ruby 2.2 compatability.
* Base64 URL decoding expects padding; updated to add padding
  as necessary.
* Spec tests did not run due to oauth/faraday version conflicts. Fixed.
Add support for cross-sdk integration tests.
7b07dc3
Usage updates.
e4dccb5
Update dockerfile so it builds properly, and add execute bit to integ…
a1fbaeb 
…ration test.
Fix bug where multiple record types caused parsing issue.
f2bc25d
ericmann
ericmann reviewed Nov 21, 2017
View reviewed changes
spec/e3db_spec.rb
client1_eak = client1.create_writer_key(type)
client1.share(type, client2_opts.client_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're removing this sharing from the tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't necessary for the test - probably a copy/paste error originally.

@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.887% when pulling f2bc25d on jgbailey/E3DB-855 into caeb739 on master.

@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.887% when pulling f8f6f6e on jgbailey/E3DB-855 into caeb739 on master.

@fernviridian fernviridian merged commit 1ab5791 into master Nov 23, 2017
@fernviridian fernviridian deleted the jgbailey/E3DB-855 branch November 23, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4dc4p m4dc4p m4dc4p approved these changes

@ericmann ericmann ericmann approved these changes

@gstro gstro Awaiting requested review from gstro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernviridian @coveralls @m4dc4p @ericmann