[WASH-930] TozID login for iOS #13
Conversation
carrala
commented
Jul 27, 2021
carrala
commented
- Adds login method for iOS, which uses the updated e3db-swift and returns a Client
- Also updated the permissions in info.plist so that http requests succeed
carrala
requested review from
efabens,
galxy25,
pirtleshell,
Mrhea,
rosasck and
sjonz
carrala
changed the title
|
Just a suggestion - make a follow up task (e.g. Jira Subtask) to make sure we unpin the e3db dependency. |
| @@ -5,21 +5,25 @@ public class E3dbSerializer { | |||
| static func realmFromJson(json: String) -> Application { | |||
| let jsonData = json.data(using: .utf8)! | |||
| let realmConfig: RealmConfigSerializer = try! JSONDecoder().decode(RealmConfigSerializer.self, from: jsonData) | |||
| return Application(apiUrl: realmConfig.apiURL, appName: realmConfig.appName, realmName: realmConfig.realmName, brokerTargetUrl: realmConfig.brokenTargetURL) | |||
| return Application(apiUrl: realmConfig.apiURL, appName: realmConfig.appName, realmName: realmConfig.realmName, brokerTargetUrl: realmConfig.brokerTargetURL) | |||
There was a problem hiding this comment.
what was broken is now fixed 🧙🏽♀️ 🧙🏽♂️
carrala
force-pushed
the
wash-930-login-identity
branch
from
960543e
to
bf8ac90
Compare
example/ios/Runner/Info.plist
Outdated
| <key>NSAppTransportSecurity</key> | ||
| <dict> | ||
| <key>NSAllowsArbitraryLoads</key><true/> | ||
| </dict> |
There was a problem hiding this comment.
just flagging that according to the docs this configuration flag will need to be justified to Apple to get this code in the app store. i'm not familiar enough with this project to know if that is a concern or if this is just some debug code to allow non-https protocol requests. just noting it may come up
You must supply a justification during App Store review if you set the key’s value to YES, as described in Provide Justification for Exceptions. Use this key with caution because it significantly reduces the security of your app. In most cases, it’s better to upgrade your servers to meet the requirements imposed by ATS, or at least to use a narrower exception.
There was a problem hiding this comment.
updated to add this context for future readers
- Adds login method for iOS, which uses the updated e3db-swift and returns a Client - Converts E3db Config to FlutterConfig so dart can decode the json. - Updates permissions to allow navigation to http addresses.
galxy25
force-pushed
the
wash-930-login-identity
branch
from
9992eff
to
d528598
Compare
galxy25
force-pushed
the
wash-930-login-identity
branch
from
d528598
to
ced9cff
Compare
