[WASH-931] Add share method to iOS plugin #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrhea
commented
Jul 30, 2021
Mrhea
requested review from
carrala,
efabens,
galxy25,
pirtleshell,
rosasck and
sjonz
Mrhea
commented
Jul 30, 2021
Mrhea
commented
Aug 3, 2021
example/lib/main.dart
Outdated
| developer.log("example flow succeeded"); | ||
| } catch (e) { | ||
| developer.log("example flow failed becaused $e"); | ||
| } |
There was a problem hiding this comment.
There was a missing brace here causing variable declaration errors that I inadvertently fixed in writing onWriteThenShareRecordButtonPress.
I did not notice this until I started a new branch off of trunk to start working on read record. Merging this will fix this, but at the moment trunk is non-functional because of it. At a glance, error was introduced in commit 7c7cd2229845d256c8a6d5f5144ce65e1ca7eb55
galxy25
approved these changes
Aug 3, 2021
carrala
approved these changes
Aug 4, 2021
efabens
approved these changes
Aug 4, 2021
- Adds a share record method to iOS plugin - Adds a new test to example app that writes then shares a record
Mrhea
force-pushed
the
wash-931-share-record
branch
from
4cb3e96
to
db86b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shares a record
Using this draft to communicate current progress on sharing records.
shareis confirmed to successfully share a record by runningonWriteThenShareRecordButtonPresstest inmain.dartthen confirming in dashboard and docker logs.The
shareResultvalue returned inshare's callback returns acryptoErrorobject when sharing a new record type, which causes execution to fall into theFlutterErrorcase. I confirmed that this was not an issue with re-sharing the same record given that doing so returns the expected409instead of acryptoError.I will mark in in-line comments where the callback returns a
cryptoError.