[WASH-931] Fix DispatchGroup typo after rebase #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds back in DispatchGroup waiting to block main thread execution for API requests that was inadvertantly removed after a merge
Mrhea
requested review from
efabens,
galxy25,
pirtleshell,
carrala,
rosasck and
sjonz
efabens
approved these changes
Aug 4, 2021
galxy25
approved these changes
Aug 4, 2021
carrala
approved these changes
Aug 4, 2021
pirtleshell
approved these changes
Aug 4, 2021
Mrhea
deleted the
wash-931-add-back-in-dispatch-group-wait-for-main-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread execution for API requests that was inadvertantly
removed after a merge
In my hubris I did not notice that my rebase removed main thread blocking by the dispatch group for read record and share record 馃う
Both methods tested again and work