Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

TransformLogLikelihood terminology #8

Open
simonbyrne opened this issue Jun 28, 2018 · 1 comment
Open

TransformLogLikelihood terminology #8

simonbyrne opened this issue Jun 28, 2018 · 1 comment

Comments

@simonbyrne
Copy link

Thanks for the package! It has a lot of really neat features.

My one nitpick is that TransformLogLikelihood is not really that accurate of a name. As I understand it, it accounts for the Jacobian term when doing the change-of-variables. But the Jacobian term is due to the fact that it's a density; likelihoods by themselves are parametrisation invariant (e.g. maximum likelihood estimates won't change).

I would suggest TransformLogDensity (since you don't need a likelihood at all, e.g. you could just be sampling from an arbitrary distribution).

@tpapp
Copy link
Owner

tpapp commented Jun 29, 2018

Good point. I am working on a new package that will replace this one, so I opened an issue there.
tpapp/TransformVariables.jl#1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants