Excel export (Sourcery refactored) #115
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| bg_color = f"#{hash_str[2:8]}" | ||
| return f"#{hash_str[2:8]}" | ||
| else: | ||
| bg_color = "#F0F0F0" | ||
| return bg_color | ||
| return "#F0F0F0" |
There was a problem hiding this comment.
Function _get_color_from_string refactored with the following changes:
- Lift return into if (
lift-return-into-if)
| if "NotAvailable" in task_name: | ||
| # hatch = "//" | ||
| # bar_color = "white" | ||
| text_to_display = "" | ||
| else: | ||
| # hatch = None | ||
| # bar_color = task_colors[task_name] | ||
| text_to_display = task_name | ||
|
|
||
| text_to_display = "" if "NotAvailable" in task_name else task_name |
There was a problem hiding this comment.
Function export_solution_to_excel_file refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
This removes the following comments ( why? ):
# hatch = None
# bar_color = task_colors[task_name]
# bar_color = "white"
# hatch = "//"
| self.assertTrue("task_1" in "%s" % t1) | ||
| self.assertTrue("task_2" in "%s" % t2) | ||
| self.assertTrue("W1" in "%s" % worker_1) | ||
| self.assertTrue("task_1" in f"{t1}") | ||
| self.assertTrue("task_2" in f"{t2}") | ||
| self.assertTrue("W1" in f"{worker_1}") |
There was a problem hiding this comment.
Function TestFeatures.test_print_objects refactored with the following changes:
- Replace interpolated string formatting with f-string [×3] (
replace-interpolation-with-fstring)
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #114 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
excel-exportbranch, then run:Help us improve this pull request!