Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to opencascade-7.5.0 #917

Closed
tpaviot opened this issue Nov 11, 2020 · 16 comments
Closed

port to opencascade-7.5.0 #917

tpaviot opened this issue Nov 11, 2020 · 16 comments

Comments

@tpaviot
Copy link
Owner

tpaviot commented Nov 11, 2020

opencascade 7.50 was released a few days ago, conda packages were updated at conda-forge https://anaconda.org/conda-forge/occt

pythonocc wrapper is being updated at https://github.com/tpaviot/pythonocc-core/tree/review/port-to-occt750

The azure build relies on the conda-forge occt 7.5.0 package, it requires some updates (32bit Windows package is not available, and MacOSX build needs some additional tweaks) see https://dev.azure.com/tpaviot/pythonocc-core/_build?definitionId=2&_a=summary&repositoryFilter=2&branchFilter=87%2C87%2C87

@tpaviot
Copy link
Owner Author

tpaviot commented Nov 11, 2020

@adam-urbanczyk @rainman110 @looooo you might be interested in following this porting effort

@tpaviot
Copy link
Owner Author

tpaviot commented Nov 11, 2020

According to the latest azure build, it seems all osx/linux/win builds complete, and all unittest pass as well

On my machine, I checked some of the pythonocc-demos, it seems also that everything is ok, I could not find any example that doesn't work with 7.5.0, but I have to check all the scripts to be sure

@looooo
Copy link

looooo commented Nov 11, 2020

A pr for a migration was already created:
conda-forge/conda-forge-pinning-feedstock@73b1681

But I am not yet sure if it's good to start with the migration now. There are other migrations also ongoing and some stuff needs to be resolved (mainly smesh + vtk9)

@tpaviot
Copy link
Owner Author

tpaviot commented Nov 11, 2020

@looooo I do not understand what you mean, I can see/download occt7.5.0 from the anaconda conda-forge channel. What do you mean with "migration" ? migration of what ?

@looooo
Copy link

looooo commented Nov 11, 2020

@looooo I do not understand what you mean, I can see/download occt7.5.0 from the anaconda conda-forge channel. What do you mean with "migration" ? migration of what ?

If the mentioned PR is merged a bot creates pr's for all occt dependent recipes to update to occt 7.5.

@tpaviot
Copy link
Owner Author

tpaviot commented Nov 11, 2020

ok I got it, thank you

@looooo
Copy link

looooo commented Feb 25, 2021

migration has started:
conda-forge/pythonocc-core-feedstock#4

what should we do?

@tpaviot
Copy link
Owner Author

tpaviot commented Feb 26, 2021

pythonocc-7.4.0 can not be compiled against occt750. I recently tagged 7.5.0rc1 https://github.com/tpaviot/pythonocc-core/releases/tag/7.5.0rc1, this version should be used. Could you @looooo update the conda-forge conda recipe to this version ?

@looooo
Copy link

looooo commented Feb 26, 2021

Should we wait for a release? @tpaviot

@looooo
Copy link

looooo commented Mar 1, 2021

@tpaviot the rc1 tag is failing for me.

@tpaviot
Copy link
Owner Author

tpaviot commented Mar 2, 2021

@looooo thank you for this feedback, what do you mean exactly with "failing for me" ? Does it successfully compile on your machine ? Does it successfully run all the unittests ? Did you build pythonocc on your own machine or on a compilation farm (conda-forge) ?

@looooo
Copy link

looooo commented Mar 3, 2021

this is the error I see in the PR:

CMake Error at CMakeLists.txt:141 (find_package):
  Could not find a configuration file for package "OpenCASCADE" that is
  compatible with requested version "7.5.0".

We try to build pythonocc against occt 7.5.1.

@looooo
Copy link

looooo commented Mar 27, 2021

@tpaviot is it possible to update the master branch to work with occt7.5.1?
https://github.com/tpaviot/pythonocc-core/blob/master/CMakeLists.txt#L143

@tpaviot
Copy link
Owner Author

tpaviot commented Mar 29, 2021

@looooo WIP

@tpaviot
Copy link
Owner Author

tpaviot commented Mar 30, 2021

@looooo done, merged into master

@luzpaz
Copy link

luzpaz commented Mar 31, 2021

Can this ticket be closed ?

@tpaviot tpaviot closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants