Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Timezone Incorrect #294

Closed
Cpt-Echo opened this issue May 1, 2023 · 7 comments
Closed

Log Timezone Incorrect #294

Cpt-Echo opened this issue May 1, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@Cpt-Echo
Copy link

Cpt-Echo commented May 1, 2023

Prefill not respecting the timezone in the container for its logs when started by Cron
Timezone is defaulting to +0 UTC

Expected behaviour - Timezone is inherited from host server or can also be set with TZ environmental variable in docker run.
Both options have been tried with no success.
Other processes within the same container (e.g. Cron) do use the correct timezone.
e.g. Cron is set to 2am to start prefill, Prefill starts correctly at 2am, however logs show 4pm (correct timezone is +10 UTC)

If Prefill is started manually through command line the logs do show the correct time.
This is only a problem when process is started by Cron

Region - Australia
Platform - Docker
Discord - Cpt Echo#3755

@tpill90
Copy link
Owner

tpill90 commented May 3, 2023

I've figured out the issue with this, and it should be fixed in the next release. Adding -e TZ=Europe/London as an environment variable should now override correctly.

@tpill90 tpill90 added the pending release Fix has been merged, needs to be published label May 3, 2023
@tpill90
Copy link
Owner

tpill90 commented May 10, 2023

Released in v2.1.0

@tpill90 tpill90 closed this as completed May 10, 2023
@Cpt-Echo
Copy link
Author

Unfortunately this fix did not work. Log still defaulting to 0 UTC even with -e TZ=Australia/Sydney (+10 UTC)
As can be seen in the log screenshot, CRON is set for 2am, and executes correctly at 2am (+10utc) , however logging shows 4pm the day prior (0 UTC)

image

@tpill90 tpill90 removed the pending release Fix has been merged, needs to be published label May 13, 2023
@tpill90 tpill90 reopened this May 13, 2023
@tpill90
Copy link
Owner

tpill90 commented Jun 28, 2023

Ah thanks for the screenshot, I think I see whats going on here. I made the fix in my Docker image, however you're using ich777's container which wouldn't have my fix in it.

@ich777 Could you take a look at this when you get a chance? I'm pretty sure that this issue can be resolved by doing the same fix that I did in this PR : https://github.com/tpill90/steam-lancache-prefill/pull/296/files

@ich777
Copy link

ich777 commented Jun 28, 2023

@Cpt-Echo thanks for the report but I have to say, next time please use the support thread on the Unraid forums since this is my container.

Please update the container itself, I've now added tzdata and it should work as intended.

@ich777
Copy link

ich777 commented Jul 2, 2023

@Cpt-Echo any update on this? Does it now work?

@tpill90
Copy link
Owner

tpill90 commented Jul 3, 2023

I'm going to close this out, and it can be reopened if the issue persists

@tpill90 tpill90 closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants