Skip to content

Commit

Permalink
build: Remove use of 'which' to check for existence of gdbus-codegen.
Browse files Browse the repository at this point in the history
This is a redundant check. AC_CHECK_PROG already finds the program on
path and ensures that it is executable.

Signed-off-by: Philip Tricca <flihp@twobit.org>
  • Loading branch information
flihp committed Jan 17, 2022
1 parent cbc98a0 commit 7ea52a7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ The format is based on [Keep a CHANGELOG](http://keepachangelog.com/)
- Initialize gerror pointer variable to NULL to fix use of unitialized memory and segfault.
- Updated missing defaults in manpage.

### Removed
- Dependency on 'which' utility in configure.ac.

### 2.4.0 - 2021-02-08
### Added
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ PKG_CHECK_MODULES([TSS2_TCTILDR],[tss2-tctildr])
PKG_CHECK_MODULES([TSS2_RC],[tss2-rc])
AC_ARG_VAR([GDBUS_CODEGEN],[The gdbus-codegen executable.])
AC_CHECK_PROG([GDBUS_CODEGEN], [gdbus-codegen], [gdbus-codegen])
AS_IF([test ! -x "$(which $GDBUS_CODEGEN)"],
AS_IF([test x"$GDBUS_CODEGEN" != x"gdbus-codegen"],
[AC_MSG_ERROR([*** gdbus-codegen is required to build tpm2-abrmd])])

# Check OS and set library and compile flags accordingly
Expand Down

0 comments on commit 7ea52a7

Please sign in to comment.