Replace references to drand48_r family of functions for portability #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srand48_r, lrand48_r, and drand48_data are GNU extensions and are not portable. This commit replaces references to these functions and data structure with functionality documented in the drand48 man page. The drand48 functionality is a part of POSIX. Signed-off-by: Safayet N Ahmed <Safayet.Ahmed@ge.com>
|
This is great @safayetahmedatge. I tagged a release candidate for a bugfix release last night (2.0.1-rc0). I will queue this up for merging into master after this release is complete. This work will end up in the next minor version release (2.1.0). |
bluca
added a commit
to bluca/meta-secure-core
that referenced
this pull request
Feb 26, 2019
Several bug fixes were merged in 2.0.1 and 2.0.3, including the following PRs that fix building tpm2-abrmd with the musl C library: tpm2-software/tpm2-abrmd#502 tpm2-software/tpm2-abrmd#503 Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
jiazhang0
pushed a commit
to jiazhang0/meta-secure-core
that referenced
this pull request
Feb 26, 2019
Several bug fixes were merged in 2.0.1 and 2.0.3, including the following PRs that fix building tpm2-abrmd with the musl C library: tpm2-software/tpm2-abrmd#502 tpm2-software/tpm2-abrmd#503 Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
parr0tr1ver
pushed a commit
to parr0tr1ver/meta-secure-core
that referenced
this pull request
Sep 15, 2020
Several bug fixes were merged in 2.0.1 and 2.0.3, including the following PRs that fix building tpm2-abrmd with the musl C library: tpm2-software/tpm2-abrmd#502 tpm2-software/tpm2-abrmd#503 Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srand48_r, lrand48_r, and drand48_data are GNU extensions and are not portable.
This PR replaces references to these functions and data structure with
functionality documented in the drand48 man page. The drand48 functionality
is a part of POSIX.
Addresses issue #500