fixes / changelog for 2.2.1 #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [commit][1] in libtpms setting auth values/policies for PCRs are no longer supported. [1]: stefanberger/libtpms@af4fc0e Signed-off-by: Erik Larsson <who+github@cnackers.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 91.57% 91.47% -0.11%
==========================================
Files 17 17
Lines 7017 7014 -3
Branches 1012 1010 -2
==========================================
- Hits 6426 6416 -10
- Misses 418 426 +8
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. |
whooo
changed the title
RSAPrivateNumbers was moved to a rust implementation in 42.0.1. So inheritance is no longer possible, so turn the class into a wrapper instead of a subclass. Fixes tpm2-software#561 Signed-off-by: Erik Larsson <who+github@cnackers.org>
Signed-off-by: Erik Larsson <who+github@cnackers.org>
whooo
changed the title
|
@williamcroberts, when you have time, could you have a look at this? |
Closed
|
Friendly ping, tpm2-pytss is broken in NixOS repositories right now because of the lack of upgrade… |
Merged
13 tasks
RaitoBezarius
added a commit
to RaitoBezarius/nixpkgs
that referenced
this pull request
Feb 10, 2024
tpm2-software/tpm2-pytss#562 is required to make tpm2-pytss work again with cryptography. Upstream seems unresponsive tpm2-software/tpm2-pytss#559. So I recommend to patch it here and remove it when we don't need it anymore. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
peterhoeg
pushed a commit
to peterhoeg/nixpkgs
that referenced
this pull request
Feb 12, 2024
tpm2-software/tpm2-pytss#562 is required to make tpm2-pytss work again with cryptography. Upstream seems unresponsive tpm2-software/tpm2-pytss#559. So I recommend to patch it here and remove it when we don't need it anymore. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
whooo
force-pushed
the
libtpms-ci-fix
branch
2 times, most recently
from
8448348
to
3083b13
Compare
This is only a temporary fix so a release can be made. Signed-off-by: Erik Larsson <who+github@cnackers.org>
|
Fixed via #565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit in libtpms setting auth values/policies for PCRs are no longer supported.