Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qualifyingdata should be file or byte array #1631

Closed
williamcroberts opened this issue Jul 31, 2019 · 1 comment · Fixed by #1822
Closed

qualifyingdata should be file or byte array #1631

williamcroberts opened this issue Jul 31, 2019 · 1 comment · Fixed by #1822
Assignees
@williamcroberts
Labels
feature
Milestone
4.1

Comments

@williamcroberts
Copy link
Member

When taking in qualifying data like in tpm2_quote, check to see if its a file and use it as binary else try and convert it from hex string
@williamcroberts williamcroberts added feature good-first-issue Issues that new contributors can easily work on help wanted labels Jul 31, 2019
@williamcroberts
Copy link
Member Author

Check all the tools

@williamcroberts williamcroberts added this to the 4.1 milestone Aug 20, 2019
@williamcroberts williamcroberts self-assigned this Oct 24, 2019
@williamcroberts williamcroberts added in progress Work is in progress on this issue and removed good-first-issue Issues that new contributors can easily work on help wanted labels Oct 24, 2019
williamcroberts pushed a commit to williamcroberts/tpm2-tools that referenced this issue Oct 29, 2019
make qualifying data a hex array or file
cd2542f 
Unify the -q option by allowing them to be a file or hex array for
inputs.

Fixes: tpm2-software#1631

Signed-off-by: William Roberts <william.c.roberts@intel.com>
@williamcroberts williamcroberts mentioned this issue Oct 29, 2019
Merged
williamcroberts pushed a commit to williamcroberts/tpm2-tools that referenced this issue Oct 29, 2019
make qualifying data a hex array or file
ba17904 
Unify the -q option by allowing them to be a file or hex array for
inputs.

Fixes: tpm2-software#1631

Signed-off-by: William Roberts <william.c.roberts@intel.com>
williamcroberts pushed a commit that referenced this issue Oct 30, 2019
make qualifying data a hex array or file
caa7791 
Unify the -q option by allowing them to be a file or hex array for
inputs.

Fixes: #1631

Signed-off-by: William Roberts <william.c.roberts@intel.com>
@williamcroberts williamcroberts removed the in progress Work is in progress on this issue label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamcroberts williamcroberts

Labels
feature
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

qualifying data as hex string or binary file and manpage fix williamcroberts/tpm2-tools
1 participant
@williamcroberts