tpm2_eventlog_yaml: fix parsing for MokListTrusted #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THS-on
force-pushed
the
mok-list-trusted
branch
from
55f6213
to
9fff9f5
Compare
This was referenced Oct 9, 2022
|
@THS-on please can you add the eventlog binary to the integration test fixtures and update the test. |
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
- Coverage 76.68% 76.62% -0.06%
==========================================
Files 172 172
Lines 23117 23216 +99
==========================================
+ Hits 17727 17790 +63
- Misses 5390 5426 +36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@idesai done. @kkaarreell I included your provided eventlog. I hope this is fine. |
THS-on
force-pushed
the
mok-list-trusted
branch
from
98fe0f5
to
1061d53
Compare
idesai
reviewed
Oct 10, 2022
Not all data in events of the EV_EFI_VARIABLE_AUTHORITY are EFI_SIGNATURE_DATA. The entry for MokListTrusted is a boolean encoded as an integer similar to SecureBoot variable. Fixes tpm2-software#3050 Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
THS-on
force-pushed
the
mok-list-trusted
branch
from
1061d53
to
bd801a1
Compare
The used variables and their length are defined as the following:
- Name: NAME_{VARIABLE_NAME}
- Length: NAME_{VARIABLE_NAME}_LEN
Signed-off-by: Thore Sommer <mail@thson.de>
|
@JuergenReppSIT, it appears all the FAPI tests are failing with master tpm2-tss branch. |
JuergenReppSIT
added a commit
to JuergenReppSIT/tpm2-tss
that referenced
this pull request
Oct 11, 2022
Memory allocated by scandir when reading the fapi profile was not freed. Should fix the failures in: tpm2-software/tpm2-tools#3144 Signed-off-by: Juergen Repp <juergen_repp@web.de>
I have create a PR which should fix the problem: tpm2-software/tpm2-tss#2434 |
JuergenReppSIT
added a commit
to tpm2-software/tpm2-tss
that referenced
this pull request
Oct 11, 2022
Memory allocated by scandir when reading the fapi profile was not freed. Should fix the failures in: tpm2-software/tpm2-tools#3144 Signed-off-by: Juergen Repp <juergen_repp@web.de>
idesai
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all data in events of the EV_EFI_VARIABLE_AUTHORITY are
EFI_SIGNATURE_DATA. The entry for MokListTrusted is a boolean
encoded as an integer similar to SecureBoot variable.
Fixes #3050