Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change engine name to "tpm2" #28

Open
dwmw2 opened this issue Oct 13, 2018 · 8 comments
Open

Please change engine name to "tpm2" #28

dwmw2 opened this issue Oct 13, 2018 · 8 comments
Labels
question Further information is requested

Comments

@dwmw2
Copy link
Contributor

dwmw2 commented Oct 13, 2018

Let's not tell applications that if they have a PEM file with -----BEGIN TSS2 PRIVATE KEY----- they need to try both tpm2 and tpm2tss engines to see which one happens to be present.

Let's instead just make them both install as tpm2. Distributions can use "alternatives" to allow for one or the other to take that engine name, as they see fit.

@AndreasFuchsTPM
Copy link
Member

@jejb What do you think about this idea ?
I don't want to name-clash without us both agreeing...

Downside is of course that you cannot work with both simultaneously...

@AndreasFuchsTPM AndreasFuchsTPM added enhancement New feature or request question Further information is requested labels Oct 16, 2018
@AndreasFuchsTPM AndreasFuchsTPM removed the enhancement New feature or request label Nov 22, 2018
@AndreasFuchsTPM
Copy link
Member

@dwmw2 @jejb What shall we do about the engine name ?
I want to ship the first release soon, so I need this final.

@dwmw2
Copy link
Contributor Author

dwmw2 commented Mar 3, 2020

Use "tpm2". Didn't I already start pointing out applications that work with that, and never try "tpm2-tss"?

@AndreasFuchsTPM
Copy link
Member

How do we do this in a backwards compatible way ?

@dwmw2
Copy link
Contributor Author

dwmw2 commented Mar 6, 2020

Should Just Work™ since right now, any application which wants to get this right, at the moment, needs to try both tpm2tss and tpm2 as engine names anyway.

e.g.

Hm, curl still doesn't have TPMv2 support. Must go poke at that again....

@AndreasFuchsTPM
Copy link
Member

I was wondering if/how we can make the transition easy for people that use tpm2tss as engine in a config file such as nginx.

Will they have to edit their config files or will it just work (tm) ?

An how does @jejb feel about this ?

@dwmw2
Copy link
Contributor Author

dwmw2 commented Mar 6, 2020

You could experiment with making it work with both engine names, perhaps using a symlink and then internally registering two engines? I wouldn't bother though.

Any software that ever relied on the user/admin hard-coding an engine name in a config file like that was Doing It Wrong. The code should have spotted the PEM headers for the TPM keys and invoked the engine automatically, like the examples I showed above. And right now, should be trying both engine names.

@AndreasFuchsTPM
Copy link
Member

It will take some days before I have time to experiment with this though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants