Use a TPM simulator for the integration tests #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been changed upstream in tpm2-software/tpm2-tools@11e5c70 Signed-off-by: Jonas Witschel <diabonas@gmx.de>
The environment variable is useful for configuring the integration tests to use a TPM simulator. Signed-off-by: Jonas Witschel <diabonas@gmx.de>
diabonas
force-pushed
the
issue-86
branch
5 times, most recently
from
e539976
to
1c09c4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 62.73% 67.43% +4.69%
==========================================
Files 9 9
Lines 1170 1176 +6
==========================================
+ Hits 734 793 +59
+ Misses 436 383 -53
Continue to review full report at Codecov.
|
diabonas
force-pushed
the
issue-86
branch
2 times, most recently
from
c9afa65
to
71d92f1
Compare
Currently the integration tests use the first TPM they find on the system. This commit starts a TPM simulator for every integration test and configures the TCTI environment variable to use it, allowing parallel execution of the tests. Signed-off-by: Jonas Witschel <diabonas@gmx.de>
Setting the environment variables and clearing the TPM is now done in
the wrapper. Furthermore as we run in a temporary directory anyway,
there is no need for ${DIR} any more.
Signed-off-by: Jonas Witschel <diabonas@gmx.de>
Avoids a port conflict when running the tests in parallel. Signed-off-by: Jonas Witschel <diabonas@gmx.de>
This is possible after the preceeding changes to the integration test harness. Signed-off-by: Jonas Witschel <diabonas@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple test harness to automatically start and use a TPM simulator for the integration tests. This is possible by using the TCTI environment variable introduced in #62, which is now enabled by default for this reason.
This has the following advantages:
Additionally this PR fixes #106 (upstream renaming of tpm2-tools options).
Closes #86