tests: enable tcti-pcap tests on big endian platforms #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
Codecov Report
@@ Coverage Diff @@
## master #2125 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 343 343
Lines 37023 37023
=======================================
Hits 31553 31553
Misses 5470 5470 Continue to review full report at Codecov.
|
utkarsh2102
reviewed
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tcti-pcap tests for big endian platforms. Fixes #2113.
There are two layers here: the pcap blocks are always dumped in host endianness. Everything else (IPv4, TCP, etc.), however, is dumped in network endianness aka big endian.
Therefore, on test layer, only the pcap-layer byte streams are affected by host endianness and need to be swapped.
This fixes the test on an s390x qemu machine with alpine.