test: fix usage of FILE in unit test fapi-io #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamcroberts
force-pushed
the
fix-FILE-musl-3.2.x
branch
from
4c9f814
to
1c4a9ee
Compare
added 2 commits
September 27, 2022 12:14
Fixes: pkg update -f Updating FreeBSD repository catalogue... Fetching meta.conf: . done Fetching packagesite.pkg: .......... done Processing entries: Newer FreeBSD version for package zziplib: To ignore this error set IGNORE_OSVERSION=yes - package: 1301000 - running kernel: 1300139 Ignore the mismatch and continue? [y/N]: pkg: repository FreeBSD contains packages for wrong OS version: FreeBSD:13:amd64 Processing entries... done Signed-off-by: William Roberts <william.c.roberts@intel.com>
The unit test had a static FILE structure used to pass to stdio FILE * routines as a dummy value to indicate to use the __real_xxx variant of the mocked function. This doesn't work when FILE is opaque as the compiler cannot figure out how much storage space is needed for a FILE struct. Fix this by passing a dummy pointer to a data type the compiler knows about and casting it to FILE pointer. Fixes: tpm2-software#2419 Signed-off-by: William Roberts <william.c.roberts@intel.com>
williamcroberts
force-pushed
the
fix-FILE-musl-3.2.x
branch
from
1c4a9ee
to
6ee0ecd
Compare
Codecov Report
@@ Coverage Diff @@
## 3.2.x #2423 +/- ##
==========================================
+ Coverage 83.41% 83.43% +0.02%
==========================================
Files 349 349
Lines 37722 37722
==========================================
+ Hits 31465 31474 +9
+ Misses 6257 6248 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test had a static FILE structure used to pass to stdio FILE * routines as a dummy value to indicate to use the __real_xxx variant of the mocked function. This doesn't work when FILE is opaque as the compiler cannot figure out how much storage space is needed for a FILE struct.
Fix this by passing a dummy pointer to a data type the compiler knows about and casting it to FILE pointer.
Fixes: #2419
Signed-off-by: William Roberts william.c.roberts@intel.com