Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash syntax #2830

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

SoapGentoo
Copy link
Contributor

* `==` is bash and not POSIX
Bug: https://bugs.gentoo.org/931239
Signed-off-by: David Seifert <soap@gentoo.org>
Copy link
Member

@AndreasFuchsTPM AndreasFuchsTPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a 4.1.2 for this ?

@SoapGentoo
Copy link
Contributor Author

4.1.2, but only if we get the command -v/which fix in too

@AndreasFuchsTPM
Copy link
Member

Ok, I'll prepare it...
Can I support you to do some testing during rc period ? Would you need tar-ball or is there something else I could do, so we have fewer bug-fix revisions ?

@AndreasFuchsTPM AndreasFuchsTPM added this to the 4.2.0 milestone May 8, 2024
@AndreasFuchsTPM AndreasFuchsTPM added the backport Issues to be backported to old-stable label May 8, 2024
@AndreasFuchsTPM AndreasFuchsTPM merged commit 03726ba into tpm2-software:master May 8, 2024
25 checks passed
@SoapGentoo SoapGentoo deleted the bashism-fix branch May 8, 2024 14:48
@SoapGentoo
Copy link
Contributor Author

sure, you can ping me during the rc phase and I will test it to check that the bashism/which things are fixed. In general, you can ping me for build system related issues, seeing how Gentoo is more likely to run into them than other distros.

@AndreasFuchsTPM
Copy link
Member

@SoapGentoo 4.1.2-rc0 is tagged.
Let me know if there are issues remaining...

@SoapGentoo
Copy link
Contributor Author

@AndreasFuchsTPM thanks, just tested it with dash and without which present and all tests have passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Issues to be backported to old-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants