-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yax #309
Merged
Merged
Yax #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Ok let's do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases and subsumes #304 … original comments below:
This adds support for two FP environments by building doobie natively for both. This means there are no shims or indirection; it's distinct builds.
This is accomplished via a preprocessor called
yax
that provides#ifdef
-style switches. It's very primitive. The high points:yax/
.core
,core_cats
, and so on. They have no source of their own and don't appear in source control, but they're generated when you run sbt and you see them undermodules/
andmodules-cats/
.-cats
, sodoobie-core-cats
,doobie-h2-cats
, and so on.Unrelated changes in this PR (sorry):
contrib
segment in artifacts and package names is gone. Sodoobie-h2
is the artifact now anddoobie.h2
is the package name.posgresql
segment and package name has been shortened topostgres
.👎 still need
publish
to understand different cross-versions